Help in java

[jairoh_]

---

naa sa ubos akong problem. edited. ty

[Klave]

First off, wala gyud kay OOP Concept gigamit for now.

Tabangan lang tika og sugod...

sa imong main tangala na tanan nimo code unya paghimo og contructor and some methods.

ang imong main should look something like this, can get shorter or longer depending on how you divide your actions.

public static void main(String args [])throws IOException
{
    BankodeJairoh myBank = new BankodeJairo();
    myBank.openBank();
}

So sa akong example sa main method, akong constructor empty, and ngadto nako gibutang ang initial action of display sa method nga openBank, so himuon sad na nimo nga method.

And from your initial code I think it is easy to point other actions which could be transferred into a method as well.

Then back to your original problem.

I think you should make the following objects too:
Account with account number and account name then child objects and Transactions.
Transactions with transaction type, date, debit amount and credit amount and optional back reference to parent Account.

since you didn't say you need to this in a database so Collection objects lang atong gamiton.

Kung create ka og account
1) make a new Account object then put in a List of Accounts.
Kung deposit
1) ask for the account number which will allow you to get the Account (naa ka option to make object nga AccountInquiry ani, input number => output Account object)
2) unya create a Transaction object with nga debit type unya debit amount ra butangan
3) Add the new Transaction object into the Account.
Kung withdraw
1) Similar steps to deposit pero credit amount ray butangan.
Kung check balance
1) retrieve the account
2) Add all transaction where all credit amounts are negative.
bali formula Balance = Summation of debits - Summation of credits.

Hopefully naa na ka idea.

For my idea learn the topic
Collection (Lists, ArrayLists, HashMap) ((Generics))

[jairoh_]

libog pajud ko brod kai wa paman gud mi OOP. introduction pa.
tudlu-e ko b. hehehe wa pako kbw unsai mga codes gamiton anang OOP gud. ipa.apply daw ang sa kanang old codes namu na basic pa gud.

[-_-]

please use the <code></code> tag para han-ay

[jairoh_]

naa nakoi nahimo mao ni pero simple ra since mao ramai gi ask sa maestro mao, gamai pa amu na lecture sa about sa OOP and array wa pako data struct. next term pa. ang problem nako ani kai magkadugay ug run ang program, nya withdraw, deposit, more accounts, deposit, withdraw, di na accurate ang check balance, lahi ang mu output. pasensya namo sa mga variables gigamit, murag redundant kai nangita man gud kog paagi ma debug. pero di ko kamao. wa pa gaie ni trappings. importante ang concept for as now. kung naa mu ma add na traps please write comment about it para mkbw ko. maypagka fast learner ko so maka.apas rako gamai. here are my codes. please help. THANKS!


================================================== ==================

Spoiler! 

package Jawokong;


public class MyBank
{


String bankName;
String bankAddress;

int [] customerID;
String [] customerFirstName;
String [] customerLastName;
double [] customerBalance;


void setBankName(String bn)
{
bankName = bn;
}

void setBankAddress(String ba)
{
bankAddress = ba;
}

void bankNameP()
{
System.out.println(bankAddress);
}

String getBankName()
{
return bankName;
}

int num = 999999999;

void setMaxCustomer( int smc)
{
customerID = new int[smc];
customerFirstName = new String[smc];
customerLastName = new String[smc];
customerBalance = new double[smc];
}

void addCustomer(int i, int id, String fn, String ln, double b)
{
customerID[i] = id;
customerLastName[i] = ln;
customerFirstName[i] = fn;
customerBalance[i] = b;
}

void setWithdrawAmount(int i, double swa)
{
customerBalance[i] -= swa;
}

void setDepositAmount(int i, double sda)
{
customerBalance[i] += sda;
}

double getBalance(int i)
{
return customerBalance[i];
}

String getCustomerFirstName(int i)
{
return customerFirstName[i];
}

String getCustomerLastName(int i)
{
return customerLastName[i];
}

int getCustomerID(int i)
{
return customerID[i];
}


}

================================================== ==

Spoiler! 

/*
* To change this template, choose Tools | Templates
* and open the template in the editor.
*/
package Jawokong;

import java.util.Arrays.*;
import java.io.*;
public class MyBankObject
{
public static void main(String args[])throws IOException
{

int cid2=0 ,cid3=0,cid4=0;
double a, ia =0;
String ln, fn ="";
int count =0,count2 = 0, count3 =0, count4 =0, index = 5, idnos=1005;
int found =0;
boolean bk =true, stop = true;


BufferedReader br = new BufferedReader(new InputStreamReader(System.in));

MyBank OpenBank = new MyBank();



OpenBank.setBankName("Banco De Jairoh");
OpenBank.setBankAddress("Dumaguete City");

OpenBank.setMaxCustomer(1000);

OpenBank.addCustomer(0,1000,"Nash","Steve",10000);
OpenBank.addCustomer(1,1001,"Parker","Tony",11000) ;
OpenBank.addCustomer(2,1002,"Nowtitzki","Dirk",120 00);
OpenBank.addCustomer(3,1003,"Anthony","Carmelo",13 000);
OpenBank.addCustomer(4,1004,"Allen","Rey",14000);
OpenBank.addCustomer(5,1005,"James","Lebron",15000 );

do{

System.out.println("[1]Create Account \n[2]Deposit \n[3]Withdraw \n[4]CheckBalance \n[5]Exit");
System.out.println("CHOOSE ALTERNATIVES");
int choose = Integer.parseInt(br.readLine());
System.out.println("");


switch(choose)
{
case 1:
System.out.println("CREATE AN ACCOUNT");
System.out.print("Last Name: ");
ln = br.readLine();

System.out.print("");

System.out.print("First Name: ");
fn = br.readLine();

System.out.print("");
do{
System.out.print("Initial Amount: ");
ia = Double.parseDouble(br.readLine());

if(ia<500)System.out.println("Initial Amount must not be less than 500$");

}while(ia<500);
index +=1;
idnos +=1;



OpenBank.addCustomer(index, idnos, fn, ln, ia);

System.out.print("");

System.out.println("Thankyou for trusting "
+OpenBank.getBankName()+ "\nYour Customer ID is "+idnos+"\nYour Balance is $"+OpenBank.getBalance(index));



break;

case 2:

System.out.println("DEPOSIT");
do{
System.out.print("Customer ID: ");
cid2 = Integer.parseInt(br.readLine());
if(cid2<1000||cid2>idnos)System.out.println("Inval id ID. Try Again.");
}while(cid2<1000||cid2>idnos);

for(;count2<OpenBank.customerID.length;count2++)
{
if(cid2==OpenBank.customerID[count2])
{

break;
}
}

System.out.println("");
System.out.println(OpenBank.customerLastName[count2]+" "+OpenBank.customerFirstName[count2]);
System.out.println("Current Balance: $"+OpenBank.getBalance(count2));

do{
System.out.print("Amount: ");
a = Double.parseDouble(br.readLine());

if(a<100)System.out.println("Amount to deposit must not be less than $100");

}while(a<100);
OpenBank.setDepositAmount(count2,a);

System.out.println("New Balance: $"+OpenBank.getBalance(count2));


break;

case 3:
System.out.println("WITHDRAW");
do{
System.out.print("Customer ID: ");
cid3 = Integer.parseInt(br.readLine());
if(cid3<1000||cid3>idnos)System.out.println("Inval id ID. Try Again.");
}while(cid3<1000||cid3>idnos);

for(;count3<OpenBank.customerID.length;count3++)
{
if(cid3==OpenBank.customerID[count3])
{

break;
}
}

System.out.println("");
System.out.println(OpenBank.customerLastName[count3]+" "+OpenBank.customerFirstName[count3]);
System.out.println("Current Balance: $"+OpenBank.getBalance(count3));

do{
System.out.print("Amount: ");
a = Double.parseDouble(br.readLine());

if(a>OpenBank.getBalance(count3))System.out.printl n("Insufficient Balance. Please try again.");

}while(a>OpenBank.getBalance(count3));
OpenBank.setWithdrawAmount(count3,a);

System.out.println("New Balance: $"+OpenBank.getBalance(count3));

break;

case 4:
System.out.println("CHECK BALANCE");
do{
System.out.print("Customer ID: ");
cid4 = Integer.parseInt(br.readLine());
if(cid4<1000||cid4>idnos)System.out.println("Inval id ID. Try Again.");
}while(cid4<1000||cid4>idnos);
for(;count4<OpenBank.customerID.length;count4++)
{
//do{


if(cid4==OpenBank.customerID[count4])
{
stop = false;
break;
}


stop = true;

//count4++;

//}while(stop);
}

System.out.println("");
System.out.println(OpenBank.customerLastName[count4]+" "+OpenBank.customerFirstName[count4]);
System.out.println("Balance: $"+OpenBank.getBalance(count4));


break;

case 5:
System.exit(0);
break;

default:
System.out.println("Invalid Input");
break;


}
System.out.println("");

}while(bk);


}
}

please use the <code></code> tag para han-ay

di ko kamao ana imo gi ingon bro sorry. di man mugana lage. hehehe

<code>wala mugana? hehe</code>

[stealthghost]

use BigDecimal.. mao na suggestion akong nakita.an basta accounting/money..

medyo libug lang unsaun pag gamit kung starter,
mogamit pud ni og NumberFormat, which is ang mo-limit sa decimal point and rounding off..

try lang search, binuang akong ISP. di ko ka-open sa site sa API.
try to search sa mga examples

[jairoh_]

use BigDecimal.. mao na suggestion akong nakita.an basta accounting/money..

medyo libug lang unsaun pag gamit kung starter,
mogamit pud ni og NumberFormat, which is ang mo-limit sa decimal point and rounding off..

try lang search, binuang akong ISP. di ko ka-open sa site sa API.
try to search sa mga examples

bro starter pako. di sa nako libugon akong utok ana kai bag.o pami lecture sa OOP, mao sa nai akong paagasan sa dugo sa akong ilong. focus sa ko ana. ang akong problem kai kanang akong gipost sa spoiler. w/c is ang current balance di mu accurate ug output kug magkadugay ug run ang program..


@klave, mao nang mu null kai wa mai sud, pero ang akong ID number nga gi input naa mai sud, di man null basta mag.run ka, pero kung magkadugay null jud ang output sa checkbalance or the last user na imong gigamit w/c is nalibog jud ko, for now kini sa akong i focus sa problem. please help mga sweto! hehehe

[jairoh_]

additional di ra diay ang check balance ang naai problema sa searching kung asa nga array makita ang ID number, hasta pud sa deposit ug withdraw, please koreksyoni akong codes sa pag.search sa location sa array, kanang mga for loops nako. please help. thanks

[-_-]

naa nakoi nahimo mao ni pero simple ra since mao ramai gi ask sa maestro mao, gamai pa amu na lecture sa about sa OOP and array wa pako data struct. next term pa. ang problem nako ani kai magkadugay ug run ang program, nya withdraw, deposit, more accounts, deposit, withdraw, di na accurate ang check balance, lahi ang mu output. pasensya namo sa mga variables gigamit, murag redundant kai nangita man gud kog paagi ma debug. pero di ko kamao. wa pa gaie ni trappings. importante ang concept for as now. kung naa mu ma add na traps please write comment about it para mkbw ko. maypagka fast learner ko so maka.apas rako gamai. here are my codes. please help. THANKS!


================================================== ==================

Spoiler! 

package Jawokong;


public class MyBank
{


String bankName;
String bankAddress;

int [] customerID;
String [] customerFirstName;
String [] customerLastName;
double [] customerBalance;


void setBankName(String bn)
{
bankName = bn;
}

void setBankAddress(String ba)
{
bankAddress = ba;
}

void bankNameP()
{
System.out.println(bankAddress);
}

String getBankName()
{
return bankName;
}

int num = 999999999;

void setMaxCustomer( int smc)
{
customerID = new int[smc];
customerFirstName = new String[smc];
customerLastName = new String[smc];
customerBalance = new double[smc];
}

void addCustomer(int i, int id, String fn, String ln, double b)
{
customerID[i] = id;
customerLastName[i] = ln;
customerFirstName[i] = fn;
customerBalance[i] = b;
}

void setWithdrawAmount(int i, double swa)
{
customerBalance[i] -= swa;
}

void setDepositAmount(int i, double sda)
{
customerBalance[i] += sda;
}

double getBalance(int i)
{
return customerBalance[i];
}

String getCustomerFirstName(int i)
{
return customerFirstName[i];
}

String getCustomerLastName(int i)
{
return customerLastName[i];
}

int getCustomerID(int i)
{
return customerID[i];
}


}

================================================== ==

Spoiler! 

/*
* To change this template, choose Tools | Templates
* and open the template in the editor.
*/
package Jawokong;

import java.io.*;
public class MyBankObject
{
public static void main(String args[])throws IOException
{
int cid2=0 ,cid3=0,cid4=0;
double a, ia =0;
String ln, fn ="";
int count =0,count2 = 0, count3 =0, count4 =0, index = 5, idnos=1005;
int found =0;
boolean bk =true, stop = true;


BufferedReader br = new BufferedReader(new InputStreamReader(System.in));

MyBank OpenBank = new MyBank();

OpenBank.setBankName("Banco De Jairoh");
OpenBank.setBankAddress("Dumaguete City");

OpenBank.setMaxCustomer(1000);

OpenBank.addCustomer(0,1000,"Nash","Steve",10000);
OpenBank.addCustomer(1,1001,"Parker","Tony",11100) ;
OpenBank.addCustomer(2,1002,"Npwtitzki","Dirk",900 00);
OpenBank.addCustomer(3,1003,"Anthony","Carmelo",80 000);
OpenBank.addCustomer(4,1004,"Allen","Rey",500000);
OpenBank.addCustomer(5,1005,"James","Lebron",80000 );

do{

System.out.println("[1]Create Account \n[2]Deposit \n[3]Withdraw \n[4]CheckBalance \n[5]Exit");
System.out.println("CHOOSE ALTERNATIVES");
int choose = Integer.parseInt(br.readLine());
System.out.println("");


switch(choose)
{
case 1:
System.out.print("Last Name: ");
ln = br.readLine();

System.out.print("");

System.out.print("First Name: ");
fn = br.readLine();

System.out.print("");
do{
System.out.print("Initial Amount: ");
ia = Double.parseDouble(br.readLine());

if(ia<500)System.out.println("Initial Amount must not be less than 500$");

}while(ia<500);
index +=1;
idnos +=1;

OpenBank.addCustomer(index, idnos, fn, ln, ia);

System.out.print("");

System.out.println("Thankyou for trusting Banco De Jairoh "
+ "\nYour Customer ID is "+idnos+"\nYour Balance is $"+OpenBank.getBalance(index));



break;

case 2:

System.out.println("DEPOSIT");
System.out.print("Customer ID: ");
cid2 = Integer.parseInt(br.readLine());


for(;1<OpenBank.customerID[count2];count2++)
{
if(cid2==OpenBank.customerID[count2])
{

break;
}
}


System.out.println(OpenBank.customerLastName[count2]+" "+OpenBank.customerFirstName[count2]);
do{
System.out.print("Amount: ");
a = Double.parseDouble(br.readLine());

if(a<100)System.out.println("Amount to deposit must not be less than $100");

}while(a<100);
OpenBank.setDepositAmount(count2,a);

System.out.println("Balance: $"+OpenBank.getBalance(count2));


break;

case 3:
System.out.println("WITHDRAW");
System.out.print("Customer ID: ");
cid3 = Integer.parseInt(br.readLine());

for(;1<OpenBank.customerID[count3];count3++)
{
if(cid3==OpenBank.customerID[count3])
{

break;
}
}

System.out.println(OpenBank.customerLastName[count3]+" "+OpenBank.customerFirstName[count3]);
do{
System.out.print("Amount: ");
a = Double.parseDouble(br.readLine());

if(a>OpenBank.getBalance(count3))System.out.printl n("Insufficient Balance. Please try again.");

}while(a>OpenBank.getBalance(count3));
OpenBank.setWithdrawAmount(count3,a);

System.out.println("Balance: $"+OpenBank.getBalance(count3));

break;

case 4:
System.out.println("CHECK BALANCE");
System.out.print("Customer ID: ");
cid4 = Integer.parseInt(br.readLine());

// for(;1<OpenBank.customerID[count4];count4++)
// {
do{

if(cid4==OpenBank.customerID[count4])
{
stop = false;
//break;
}
count4++;

}while(stop);
//}

System.out.println(OpenBank.customerLastName[count4]+" "+OpenBank.customerFirstName[count4]);
System.out.println("Balance: $"+OpenBank.getBalance(count4));


break;

case 5:
System.exit(0);
break;

default:
System.out.println("Invalid Input");
break;


}
System.out.println("");

}while(bk);


}
}

di ko kamao ana imo gi ingon bro sorry. di man mugana lage. hehehe

<code>wala mugana? hehe</code>

ilisi ang <> into [], mao daiy na ako pasabot
inig reply nimo click `Go Advanced` naa diha advanced tags ug ang code na tag

[Klave]

Bai, una complicated gamay imong gunit sa INDEX.

Adto na ibutang imong index handling sulod sa MyBank ayaw sa main.
Pwede raman unta to, pero kung imong hunahunaon ang banko man mag monitor pila na ilang customer accounts.
so tada AddCustomer nimo didto ka magadd sa MyBank nimo og +1 sa accounts available.
So more than your problem sa balance dili ko sure namaintain niya iyang index handling which in turn will cause errors sa ubang values.

Also imong balance ayaw keep og balance nga variable. Kana imong OpenBank.getBalance(int index). Ipa-recalculate niya tanan transactions available sa account. I add tanan debit, minus tanan credit.

One more question, pwede mo mugamit og Collection objects instead of arrays?

Based sa akong suggestion sa index mao ni code.

package Jawokong;


public class MyBank
{


String bankName;
String bankAddress;

int [] customerID;
String [] customerFirstName;
String [] customerLastName;
double [] customerBalance;

int i = 0;


void setBankName(String bn)
{
bankName = bn;
}

void setBankAddress(String ba)
{
bankAddress = ba;
}

void bankNameP()
{
System.out.println(bankAddress);
}

String getBankName()
{
return bankName;
}

int num = 999999999;

void setMaxCustomer( int smc)
{
customerID = new int[smc];
customerFirstName = new String[smc];
customerLastName = new String[smc];
customerBalance = new double[smc];
}

void addCustomer(int i, int id, String fn, String ln, double b)
{
customerID[i] = id;
customerLastName[i] = ln;
customerFirstName[i] = fn;
customerBalance[i] = b;
i++;
}

void setWithdrawAmount(int i, double swa)
{
customerBalance[i] -= swa;
}

void setDepositAmount(int i, double sda)
{
customerBalance[i] += sda;
}

double getBalance(int i)
{
return customerBalance[i];
}

String getCustomerFirstName(int i)
{
return customerFirstName[i];
}

String getCustomerLastName(int i)
{
return customerLastName[i];
}

int getCustomerID(int i)
{
return customerID[i];
}


}