Help Again! My C Program not giving the desired output

[marcdaven]

Mga bro, naa miy assignment sa among IT class. One of the problems was to solve for a quadratic formula. I already have made a C program out of it pero it doesn't seem to give the desired output. T_T

Mao ni akong program:

#include<stdio.h>
#include<conio.h>
#include<math.h>
int main()
{
 int a, b, c;
 long double rt1, rt2, div, key;
 clrscr();
 printf("Enter three integers separated by a space: ");
 scanf("%d %d %d", &a, &b, &c);
 div=b*b-(4*a*c);
 if (a==0)
  printf("The given constants does not represent a quadratic equation");
 else if (div>=0)
 {
  key=sqrt(div);
  rt1=((-1*b)+key)/(2*a);
  rt2=((-1*b)-key)/(2*a);
  printf("Quadratic Root one: %f", rt1);
  printf("\nQuadratic Root two: %f", rt2);
 }
 else
  printf("Constants cannot represent the quadratic formula");
 getch();
}

Any help is greatly appreciated! Thanks mga bro!

[MarkCuering]

1. consider using float and not double.
2. your root1 & root2 have the same formula in any situation? are you sure about this?
3. how do you handle distinct roots? equal roots? and complex roots?
4. the way you find discriminant seems okay.
5. make use of fabs() function in C, you might need it to combined with sqrt() func.

[hizuka007]

aguy, quadratic equation.... pass ko ani, pirting bugua bya nako aning math.. nyehehehehe

[marcdaven]

1. consider using float and not double.
2. your root1 & root2 have the same formula in any situation? are you sure about this?

They are actually different. The formula is this:



That's why ang root 1 kay add while ang root 2 kay minus...

3. how do you handle distinct roots? equal roots? and complex roots?
4. the way you find discriminant seems okay.

I get what you mean by the discriminant pero wala ko naka G sa imong distinct roots, equal roots and complex roots bro... T_T

5. make use of fabs() function in C, you might need it to combined with sqrt() func.

Going to try this...

[marcdaven]

5. make use of fabs() function in C, you might need it to combined with sqrt() func.

So far, I have been comparing given examples sa books nako diri sa amo with the output sa program and it turned out nga ning tugma sila. The fabs() function did help me in this.

You're the best MarkCuering!

[baning]

nag nose bleed ko ani na thread... first nako ni ma bangga na terms...

[ChaosOrb]

nosebleed pud ko ani. :P



MarkCuering can take care of that marcdaven....

[MarkCuering]

I get what you mean by the discriminant pero wala ko naka G sa imong distinct roots, equal roots andcomplex roots bro T_T

dba you get the discriminant?

if discriminant > 0 = is it disctinct roots?
if discriminant == 0 is it equal roots?


check this site: Solve Quadratic Equations Using Discriminants (1)

If D > 0, the equation has 2 real solutions. (see example 1 below)
If D = 0, the equation has 1 real solution. (see example 2 below)
If D < 0, the equation has 2 conjugate imaginary solutions. (see example 3 below)


some pseudocode:

1. get discriminant b*b-4*a*c
2. check if disriminant > 0 or equal to 0.
3. if > 0: our root1 is (-b+sqrt(d))
and root2 is (-b-sqrt(d))/(2*a)
4. if discriminant == 0 our root1=root2=-b/(2*a)
5. figure it out the last one ^_^


I suggest to change your variable name to these: a,b,c,x1,x2,d