Design Pattern, Implementation Pattern and Best Practices

[MarkCuering]

what if choice is integer, and 0 is considered false..

I think boolean expressions evaluate 0 as false.

you can have like this:

if(getChoice()) or if(!getChoice()) or if(getChoice() > 0)

What language and compiler you are referring by the way?

other than that, I normally don't place function in any of my "if statement", where I need the funcion's returned value/reference, and the function itselfs is having another function calls or any small-medium operations, that makes some overhead.

eg.

if(MyFunc())
{
x = MyFunc();
}

the above code process functions twice.


Real world situation.


a function that returns two element, first is boolean, second is an object.

BAD CODE:

if(MyFunc()[0])
{
anObject = MyFunc()[1];
}

GOOD CODE:

anObject=MyFunc();

if(anObject[0])
{
//do whatever you want in anObject[1];
}

if ((bool) choice)

and I seldom/haven't seen a code casting some variable to boolean type, integer can be treated as boolean values, however boolean type variables are two bits size only.

[bluedes]

if(MyFunc()[0]) 
{
   anObject = MyFunc()[1];
}

what kind of function call is that? unless ur function returns an array, why not reference the array directly.. obviously that is bad code.. anybody can see that..

and I seldom/haven't seen a code casting some variable to boolean type, integer can be treated as boolean values, however boolean type variables are two bits size only.

that is why if you don't have implicit conversion, ur integer in if statement will resort to a compiler error..




this:

if (oldChoice = getChoice())

is totally different from this:

if (oldChoice == getChoice())

so if you want to be clear, its better to put the function on the left side

if (getChoice() == oldChoice)

or.. as i have suggested earlier, the constant on the left side..

if (8080 == port)

if ("YES" == response)

if (true == choice)

[MarkCuering]

from your previous post: I replaced the "TRUE" to 0.

if ( variable == 0 )

when mistakenly written as

if ( variable = 0 )

will not trigger a compiler error even though logically, error na na..

when you write:

if ( variable = 0 )

my compiler triggered this as an error, that's why I keep asking you what compiler you are talking here? what specific language?

but kung balehon nimo..

if ( TRUE == variable )

a mistake like this

if ( 0 = variable )

will be spotted by compiler right away..

I agree on this, coz you cannot assign variables to any numeric/constant values, but if my compiler detects an error from previous approached why should I do this in the first place right?

again, my compiler does not allow "=" to be at any of conditional expression... although my old compiler allows it, but if you perform "syntax check" it detects the error.

that is why if you don't have implicit conversion, ur integer in if statement will resort to a compiler error..

returning as an error is an advantage for me

what kind of function call is that? unless ur function returns an array, why not reference the array directly.. obviously that is bad code.. anybody can see that..

yes it returns an array. I already explained that

not all can see that, believe me , they are doing more likely similar to this scenerio.

if(Multiply(num1, num2) <> 0)
{
t = Multiply(num1, num2);
}

if you have worked with MFC library you can find like that... that's why people are force to make some direct Windows API Calls, to avoid overhead, eventhough you can get it to 3-5 lines of code using MFC.

[bluedes]

from your previous post: I replaced the "TRUE" to 0.



when you write:

if ( variable = 0 )

my compiler triggered this as an error, that's why I keep asking you what compiler you are talking here? what specific language?

obviously, if your compiler triggered an error, then it has specific checks for that sa iyang hash-table during compilation..

its pointless to answer your question what kind of compiler i'm using.. obviously, my compiler does not trigger that error, that's why i suggested those tips in if statements..

and if your compiler triggers an error, then obviously, you cannot use those kinds of if conditions..

does your compiler trigger an error if ingon ani:

if (choice = getChoice())

and somewhere along the code

func getChoice()
{
   return 0;
}

.
.

I agree on this, coz you cannot assign variables to any numeric/constant values, but if my compiler detects an error from previous approached why should I do this in the first place right?

again, my compiler does not allow "=" to be at any of conditional expression... although my old compiler allows it, but if you perform "syntax check" it detects the error.

you don't.. ang2x naman buhaton pa nimo, klaro ana na mu-error sa imong compiler.. but what if your code is ported to another compiler?? its up to you.. these are just guidelines or suggestions, they're not hard-and-fast rules na you have to absolutely follow..

ang title sa thread is Best Practices diba..

don't be so in love with your compiler bro..

[bluedes]

if you have worked with MFC library you can find like that... that's why people are force to make some direct Windows API Calls, to avoid overhead, eventhough you can get it to 3-5 lines of code using MFC.

sorry, but MFC suckz... that's the slowest foundation classes i've ever tried to work with..

[MarkCuering]

no I'm not... it's just my opinion I feel it may be applicable to other Intepreted language, like python. but python, returns SyntaxError. I don't know about the other.

Yup, early days of MFC burdens anyone with massive difficulties to use and familiarize, (version 4.x, 6.0x, etc...) there's no proper documentation, which is really awful. But there are huge changes at MFC 8.x++ along with the Visual Studio 2005/.Net2.0, which is a great effort...bad side, troubles Microsoft with lots of backward compatibility issues.

[bluedes]

no I'm not... it's just my opinion I feel it may be applicable to other Intepreted language, like python. but python, returns SyntaxError. I don't know about the other.

Yup, early days of MFC burdens anyone with massive difficulties to use and familiarize, (version 4.x, 6.0x, etc...) there's no proper documentation, which is really awful. But there are huge changes at MFC 8.x++ along with the Visual Studio 2005/.Net2.0, which is a great effort...bad side, troubles Microsoft with lots of backward compatibility issues.

i don't like MFC.. but .Net is forgivable.. pero hinayan japon ko..

its nice na .Net is a very comprehensive framework..

[MarkCuering]

watch on intel website, they will now specialized their cpu's for .NET support. more results can be seen on latest Winddows 7.0

[softtouch]

in C++, I saw some people do this way
if (8080==port)

Yes, I saw this too, quiet weird in my opinion...

Make more sense for me when if (mymoney == 100 pesos) then if (100pesos == mymoney)

[Artoy]

I saw this code in one printer driver code. Their reason is same as what bluedes said.